Hello Tristan,

Now I have a first working version of signal selection. Currently it supports only full name signals, meaning that wildcards aren't supported yet (that's number 3 in your list of important features). And currently it works only for the ghw wave format, but before I extend it to all formats, do you prefer that I make a pull request now to let you review my code or should I first add the support for all formats ? And I still need to add a help description and the new option I made (--wave-option-file).

Some open questions :

- Currently when the same signal is written several times in the wave option file, this is silently ignored. Does it worth it to add a tag to my tree in order to be able to catch that and make it an error/warning ?

- When the wave option file is void of any signal, then all the signals will be displayed just like if no wave option file was provided. Should it instead display no signals at all ?

Regards,
Jonas


Le 09.07.16 à 07:20, Tristan Gingold a écrit :
On 09/07/16 06:59, Jonas Baggett wrote:
Hello Tristan,

On 07/07/16 18:50, Jonas Baggett wrote:
Hello Tristan,

There is also the case of signals in a package : I would suggest the
following syntax : pkg.the_signal. It seems better to me than
/pkg/the_signal.

Why ?  /pkg/the_signal is more regular.
Note you can have two packages with the same name in two different
libraries, so maybe it should be /lib/pkg/the_signal.  It is also
possible for an entity to have the name of a library, so maybe it
should be /@lib/pkg/the_signal.  At this point we almost follow
the syntax of external path names except '/' is used instead of '.'.
Because it's with this synthax that we access the signal in VHDL. So I
thought that when someone reads lib.pkg.the_signal, it will be clear to
him at first glance that we are accessing a signal inside a package.
Nevertheless, with the /@lib/pkg/the_signal synthax, it's also clear.
Then if you prefer this synthax, it's fine to me too.

/ or . is ok with me. I just didn't understand why package signal names were different.

Now I have finished to do the file parser and the tree builder. I have
one question : I tried to use the Types package located in src/types.ads
from my package located in src/grt but I get a compile error as the
compiler can't find it because it is at level - 1. Is it possible to
achieve that ?

No, it is not possible. The files in src/grt are the one for the runtime (used during simulation). They are completely independent from compiler files (src and src/vhdl).

I agree it is not very clear as grt/ is within src/. Maybe grt/ should be moved ?

PS : Good luck for France tonight .

Usually France looses against Germany
Except this time ;).

Surprises happen.

Tristan.


_______________________________________________
Ghdl-discuss mailing list
Ghdl-discuss@gna.org
https://mail.gna.org/listinfo/ghdl-discuss


_______________________________________________
Ghdl-discuss mailing list
Ghdl-discuss@gna.org
https://mail.gna.org/listinfo/ghdl-discuss

Reply via email to