Hello,
And currently
it works only for the ghw wave format, but before I extend it to all
formats, do you prefer that I make a pull request now to let you review
my code or should I first add the support for all formats ?
Why not starting review now ?
Ok, I am just doing some finitions, then I will update my remote
(probably tomorrow) so you can review my work.
And I still
need to add a help description and the new option I made
(--wave-option-file).
Some open questions :
- Currently when the same signal is written several times in the wave
option file, this is silently ignored. Does it worth it to add a tag to
my tree in order to be able to catch that and make it an error/warning ?
Not sure. With wildcards duplicate may be more common.
I finally added a warning in case of duplicate lines which is clearly a
mistake, but it won't display a warning in the following case, after I
will add wildcards support :
/top/*
/top/a # useless because of /top/*
But at least it is less choking for the eyes and I can still think about
that in the future.
- When the wave option file is void of any signal, then all the signals
will be displayed just like if no wave option file was provided. Should
it instead display no signals at all ?
I think this is ok. Displaying no signals is not very interesting!
Might worth emitting a warning.
Done.
There is still a case when it is possible that no signals will be
displayed. It is when the user makes a typo like :
/too/* # instead of /top/*
A warning should be emitted that /too/a wasn't in the design. I am
planning to add tomorrow the necessary checks to see if each signal on
the list corresponds to a signal in the compiled design. And in the
example above, if /too/* was the sole line, then we will end up with no
signal at all to display.
Thank you for all your efforts!
And thanks for your support !
Greetings,
Jonas
_______________________________________________
Ghdl-discuss mailing list
Ghdl-discuss@gna.org
https://mail.gna.org/listinfo/ghdl-discuss
