Hello,
On 19/07/16 12:10, Jonas Baggett wrote:
Now I have a first working version of signal selection. Currently it supports only full name signals, meaning that wildcards aren't supported yet (that's number 3 in your list of important features).
Great!
And currently it works only for the ghw wave format, but before I extend it to all formats, do you prefer that I make a pull request now to let you review my code or should I first add the support for all formats ?
Why not starting review now ?
And I still need to add a help description and the new option I made (--wave-option-file). Some open questions : - Currently when the same signal is written several times in the wave option file, this is silently ignored. Does it worth it to add a tag to my tree in order to be able to catch that and make it an error/warning ?
Not sure. With wildcards duplicate may be more common.
- When the wave option file is void of any signal, then all the signals will be displayed just like if no wave option file was provided. Should it instead display no signals at all ?
I think this is ok. Displaying no signals is not very interesting! Might worth emitting a warning. Thank you for all your efforts! Tristan. _______________________________________________ Ghdl-discuss mailing list Ghdl-discuss@gna.org https://mail.gna.org/listinfo/ghdl-discuss
