-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Sven,

Am Sa den 16. Feb 2008 um 16:55 schrieb Sven Neumann:
> I am not convinced that your patch is doing the right thing.

What is the thing that is not clear? It is exactly what in the
documentation to g_get_home_dir is described.
(http://library.gnome.org/devel/glib/unstable/glib-Miscellaneous-Utility-Functions.html#g-get-home-dir)

> But it definitely adds too much complexity to the code.

I see no point how to make it more simple. 3 lines vs. one line is not
that more complexity.

> It would be better to define gimp_get_home_dir() in
> libgimpbase/gimpenv.c und use that all over the place.

Sure, can be done. And might be more abstract. But in that case please
define the stuff inline else the overhead for the function call would be
to high.

Regards
   Klaus
- -- 
Klaus Ethgen                            http://www.ethgen.de/
pub  2048R/D1A4EDE5 2000-02-26 Klaus Ethgen <[EMAIL PROTECTED]>
Fingerprint: D7 67 71 C4 99 A6 D4 FE  EA 40 30 57 3C 88 26 2B
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iQEVAwUBR7cOeJ+OKpjRpO3lAQIKBAf6A9yv5soB+FiUKE51KvrskaJIEW3GoXRH
BEMsPxzjZFXscFUB7NVOI5qSzWnhDvAHCM11CjDgWOyv9vhm1zX87thUcdN9rkhW
IzBIZSma9YaGmDQkB+dXG0eXBOAd3UqsXj6SMDWu8UuK0peNYSUtJSO6T8af8NkC
Bvei4VWtzP6GAk+OnHyjrbLGvmS/rwbQRnXLTmr/O4LOGeFESgjJbB3MBVS3Ws2J
YZDKReJOjWEE4AO7DwX5gEqDaA1ka3o5CTqGNYHgGV+5zksYEhUVjySqpHwpta8M
ChVPHJnCMWrdbZ96a8pXhrhsXYQ81j6ygla8vyyI8CuUlN9PDcLgIw==
=VvJ4
-----END PGP SIGNATURE-----
_______________________________________________
Gimp-developer mailing list
Gimp-developer@lists.XCF.Berkeley.EDU
https://lists.XCF.Berkeley.EDU/mailman/listinfo/gimp-developer

Reply via email to