Jason Riedy <[EMAIL PROTECTED]> writes:
> And Junio C Hamano writes:
> - It turns out that your patch breaks GCC build
> Whoops, sorry. Your fix works with Sun's cc.
> BTW, how would people feel about replacing the
> setenv() and unsetenv() calls with the older putenv()?
> The Solaris version I have to work on doesn't have
> the nicer functions (and I'm not an admin). I have
> to check that the unsetenv() in git-fsck-cache.c works
> correctly as a putenv before I send along a patch.
No comment on this one at this moment until I do my own digging
> There's also the issue that /bin/sh isn't bash, but an
> installation-time helper script can fix that.
My personal preference is to rewrite parts that are easily
unbashified first before going that route, but I suspect that it
would end up being the best practical solution to simply admit
that we depend on bash, start our scripts with "#!/bin/bash",
and rewrite them "#!/usr/local/bin/bash" upon installation;
modulo that it may be a stupid and ugly workaround.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html