Marcin Owsiany <mar...@owsiany.pl> wrote:
> On Wed, Jul 11, 2012 at 03:56:43PM -0700, Junio C Hamano wrote:
> > If the caller does not handle errors, it could be even clearer to
> > write it like
> > command_noisy(qw(update-ref HEAD), $gs->refname) ||
> > die "Cannot update HEAD!!!";
> Turns out that command_noisy()
> - has a meaningless return value
> - throws an exception on command failure
> so the "||" bit does not work.
> Also, for some reason command_noisy does not check for the command being
> killed by a signal, so I'd prefer to leave the verify_ref there.
Ugh, I always forget the Git.pm API, too. Perhaps command_noisy should
be made to respect signals in exit codes (the rest of git-svn is
compromised by this behavior in command_noisy, too, it turns out... :x)
I'm not sure what else would break if command_noisy were changed,
git-svn appears to be the only user in git.git.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html