Ralf Thielow <ralf.thie...@gmail.com> writes:

> On Fri, Sep 7, 2012 at 9:32 PM, Junio C Hamano <gits...@pobox.com> wrote:
>>> -             fprintf(stderr, _("hint: %.*s\n"), (int)(np - cp), cp);
>>> +             fprintf(stderr,  "%s %.*s\n", prefix, (int)(np - cp), cp);
>> Hrm, naively, printf("%s: %.*s\n", _("hint"), ...) might look more
>> natural, but I vaguely recall that the current code places _()
>> around the entire "hint: %.*s\n" on purpose.  IIRC, it was to allow
>> translations that flow from RTL e.g. ".siht od t'nod :tnih".
>> Doesn't this patch break it?
> Sorry but I don't know what you mean with "translations that flow
> from RTL e.g. ".siht od t'nod :tnih"." so I can't check this.
> As far as I can see the callers only put a simple message in it,
> e.g. advise(_("Commit your changes or stash them to proceed."));
> So I don't think that this patch would break anything.

Your patch would not allow target languages that want to put the
_("hint") at the *tail* end of each line of the message.  With the
original, with something like this:

        msgid "hint: %.*s\n"
        msgstr "%.*s :tnih\n"

you could do that if you wanted to.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to