Nguyễn Thái Ngọc Duy <> writes:

> grep searches for .gitattributes using "name" field in struct
> grep_source but that field is not real on-disk path name. For example,
> "grep pattern rev" fills the field with "rev:path", and Git looks for
> .gitattributes in the (non-existent but exploitable) path "rev:path"
> instead of "path".
> This patch passes real paths down to grep_source_load_driver() when:
>  - grep on work tree
>  - grep on the index
>  - grep a commit (or a tag if it points to a commit)
> so that these cases look up .gitattributes at proper paths.
> .gitattributes lookup is disabled in all other cases.
> Initial-work-by: Jeff King <>
> Signed-off-by: Nguyễn Thái Ngọc Duy <>
> ---

Looks sensible and straightforward.  Thanks.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to