Hi all, On Mon, 29 Oct 2012, Jeff King wrote:
> On Mon, Oct 29, 2012 at 10:47:04PM +0100, Felipe Contreras wrote: > > > >> Yeah, the test script is not ready for merging, it needs to check > > >> for python, hg, and hg-git. > > >> > > >> Do you have hg-git installed? > > > > > > No. But it's important that it fail gracefully; I can't even take it > > > in pu if I can't run the test suite in a sane way. > > > > The contrib part is fine for 'pu'. The tests aren't even meant to > > exercise stuff in 'contrib', right? There might be some exceptions, > > but either way, there's plenty of stuff in 'contrib' without any > > tests. The tests I'm providing are simply a little sugar. > > Yeah, contrib is a bit of a wildcard. Most things do not have tests. Given that the tests of remote-hg as in git://github.com/msysgit/git's 'devel' branch run just fine without additional dependencies (which probably triggered the not-quite-constructive and unnecessarily-flaming "bloated" comment of Felipe), and given that the code in said branch is well-tested and exercised by daily use, and given the fact that my major concern was not understood (and probably not addressed), and also given the fact that Sverre indicated that he could finalize the work as a 20% project, I decided that other projects I have to do unfortunately have a too-high priority to take care of testing and measuring the performance of the patch series that is discussed in this thread. Sorry, Johannes P.S.: I would still recommend to have a detailed look at the 'devel' branch, in particular the commits starting with "fast-export: do not refer to non-existing marks" and ending with "t5801: skip without hg". My understanding is that it was completely ignored after a brief and maybe too-cursory look. In the least, it has a couple of lessons we learnt the hard way, and if git.git is dead set on duplicating the work, making these mistakes again could be avoided by learning from our lessons. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
