On Thu, Dec 20, 2012 at 3:34 PM, Jeff King <p...@peff.net> wrote:
> On Sun, Dec 16, 2012 at 07:01:56PM +0000, Adam Spiers wrote:
>> On Sun, Dec 16, 2012 at 6:54 PM, Junio C Hamano <gits...@pobox.com> wrote:
>> > Adam Spiers <g...@adamspiers.org> writes:
>> >> This series of commits attempts to make test output coloring
>> >> more intuitive,...
>> > Thanks; I understand that this is to replace the previous one
>> > b465316 (tests: paint unexpectedly fixed known breakages in bold
>> > red, 2012-09-19)---am I correct?
>> Correct. AFAICS I have incorporated all feedback raised in previous
>> > Will take a look; thanks.
>> Thanks. Sorry again for the delay. I'm now (finally) resuming work
>> on as/check-ignore.
> I eyeballed the test output of "pu". I do think this resolves all of the
> issues brought up before, and I really hate to bikeshed on the colors at
> this point, but I find that bold cyan a bit hard on the eyes when
> running with "-v" (where most of the output is in that color, as it
> dumps the shell for each test). Is there any reason not to tone it down
> a bit like:
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 256f1c6..31f59af 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -227,7 +227,7 @@ then
> tput setaf 2;; # green
> - tput bold; tput setaf 6;; # bold cyan
> + tput setaf 6;; # cyan
> test -n "$quiet" && return;;
Good point, I forgot to check what it looked like with -v. Since this
series is already on v6, is there a more lightweight way of addressing
this tiny tweak than sending v7?
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html