Re: [PATCH 2/4] t0024, t5000: use test_lazy_prereq for UNZIP

[René Scharfe]

Am 07.01.2013 09:45, schrieb Jonathan Nieder:

René Scharfe wrote:

--- a/t/t0024-crlf-archive.sh
+++ b/t/t0024-crlf-archive.sh
@@ -5,6 +5,11 @@ test_description='respect crlf in git archive'
  . ./test-lib.sh
  GIT_UNZIP=${GIT_UNZIP:-unzip}

+test_lazy_prereq UNZIP '
+       "$GIT_UNZIP" -v >/dev/null 2>&1
+       test $? -ne 127

Micronit: now that this is part of a test, there is no more need to
silence its output.  The "unzip -v" output could be useful to people
debugging with "t0024-crlf-archive.sh -v -i".

Oh, yes, good point.

With or without that change, this is a nice cleanup and obviously
correct, so
Reviewed-by: Jonathan Nieder <jrnie...@gmail.com>

Thanks,
René

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html