On 2019-08-09 at 11:36:14, Jeff King wrote: > I think you could do this with: > > size_t len; > if (strip_suffix(patch->new_name, GITATTRIBUTES_FILE, &len) && > len > 0 && is_dir_sep(patch->new_name[len-1])) > flush_attributes = 1; > > Not sure if that is better or worse. It avoids the extra memory > boilerplate, but the logic is a slightly more subtle.
I think an approach like that would be fine with a comment. I'm not sure this exact approach works with -p0, though, so I'll have to tweak it a bit. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204
Description: PGP signature