Having read Dscho's response after already writing this reroll, I think
it is a compelling case to rewrite as a C builtin, although I'm worried
a little about the best way to continue to call porcelain commands to
protect against bitrot.

Regardless, I think the proof of concept in patch 2/2 still deserves
review; likely a reimplementation in C would see
git-bugreport-config-whitelist generated in a similar way, but as a
header instead of a textfile. So I'm still very interested in comments
on the direction and the Makefile changes there.

The patch 1/2 changes are primarily based on Stolee and Junio's
suggestions; thanks both. There's some rewording of manpage and commit
message, as well as fixes when I realized this command did not work as
expected from a worktree created with `git worktree add`. I also moved
the reflog contents to the very bottom of the output as they're likely
harmless, but very verbose; I didn't want the user to stop reading and
never examine the shorter and scarier generated output, like the config.

Thanks for thoughts.
 - Emily

Emily Shaffer (2):
  bugreport: add tool to generate debugging info
  bugreport: generate config whitelist based on docs

 .gitignore                             |   2 +
 Documentation/config/sendemail.txt     |  68 ++++++------
 Documentation/git-bugreport.txt        |  51 +++++++++
 Makefile                               |  10 +-
 bugreport-generate-config-whitelist.sh |   4 +
 command-list.txt                       |   1 +
 git-bugreport.sh                       | 139 +++++++++++++++++++++++++
 git-sh-setup.sh                        |   2 +
 t/t0091-bugreport.sh                   |  25 +++++
 9 files changed, 267 insertions(+), 35 deletions(-)
 create mode 100644 Documentation/git-bugreport.txt
 create mode 100755 bugreport-generate-config-whitelist.sh
 create mode 100755 git-bugreport.sh
 create mode 100755 t/t0091-bugreport.sh


Reply via email to