On Mon, Apr 8, 2013 at 9:06 PM, Ramkumar Ramachandra <artag...@gmail.com> wrote:
> Duy Nguyen wrote:
>> Probably off-topic, but I'm starting to find ".gitignore can be found
>> in every directory" a burden to day-to-day git operations. So imo it's
>> not done right entirely ;-)
> Why is it a burden? I would argue that the tooling support is not yet
> there, but git check-ignore is a step in the right direction. What
> alternate design would you propose, just out of curiosity?
You don't know if .gitignore is there, so you need to check for it in
every directory. If we fixed its location (e.g. worktree's top) we
would not have to look in every directory. Then again it may be a bit
inconvenient that way. If you remove a directory, you also remove
.gitignore rules inside when you distribute .gitignore files.
Otherwise you need to clean up top .gitignore once in a while.
> 1. The inspiration for fixing fundamental design problems comes from
> my redesign. For instance, I would've never discovered the git add
> bug if I'd not attempted to git add (as opposed to the unnatural
> abstraction that git submodule add presents).
I actually spotted a similar use of git-add in the test suite . You
see, it's a bug that should be fixed but in that particular case, it's
valid to add something "inside a submodule". I wanted to fix that with
my read_directory rewrite (part of the pathspec stuff) but never got
around to finish it and eventually gave up, which leads to your next
> 2. I think it is absolutely imperative that we do the redesign now,
> before we've descended too far into the madness that the current
> design is. I think I'm capable of doing the redesign now, with some
> help and support from the list. My attitude doesn't align with the
> "I'm feeling lazy; why don't we postpone it?" argument. Let's finish
> what I started now: I'm more than willing to dedicate the next few
> months full-time towards finishing this and getting it merged.
Good luck. Bug such a big work usually requires more than one
volunteer. If you haven't convinced (*) the community it's right,
maybe you should take a few days thinking about it again before
(*) just a feeling after a quick glance, I may be terribly wrong again
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html