On Sat, Apr 20, 2013 at 8:05 PM, Michael Heemskerk <[email protected]> wrote: > When the client sends a 'shallow' line for an object that the server does > not have, the server currently dies with the error: "did not find object > for shallow <obj-id>". The client may have received the object from a > different server, or the object may have been garbage collected by the > server. In either case, the object is not relevant for calculating the pack > that is to be sent and can be safely ignored. > > The documentation in technical/pack-protocol.txt has been updated to > remove the restriction that "Clients MUST NOT mention an obj-id which it > does not know exists on the server". This requirement is not realistic > because clients cannot know whether an object has been garbage collected > by the server. > > Signed-off-by: Michael Heemskerk <[email protected]>
I'm not an expert in git protocol (or shallow extension in particular) but the reasoning sounds right and the implemention looks correct. Acked-by: Duy Nguyen <[email protected]> -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
