"Kyle J. McKay" <mack...@gmail.com> writes:

> +     if (!strcmp("sslcertpasswordprotected", key)) {
> +             if (check_matched_len(opt_passwd_req, matchlen))
> +                     return 0;
>               if (git_config_bool(var, value))
>                       ssl_cert_password_required = 1;
>               return 0;
>       }

This is not a new problem, but I think the existing code is wrong.
There is no way to countermand an earlier

        [http]
                sslcertpasswordprotected

in a more generic configuration file with


        [http]
                sslcertpasswordprotected = no

in a repository specific configuration file.

Perhaps we should fix it as a preparatory patch (1/2) before the
main "feature addition" patch.

> -     if (!strcmp("http.ssltry", var)) {
> +     if (!strcmp("ssltry", key)) {
> +             if (check_matched_len(opt_ssl_try, matchlen))
> +                     return 0;
>               curl_ssl_try = git_config_bool(var, value);
>               return 0;
>       }
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to