On Wed, Dec 11, 2013 at 11:26:17PM +0100, Jens Lehmann wrote:
> Am 10.12.2013 00:40, schrieb Junio C Hamano:
> > Heiko Voigt <hvo...@hvoigt.net> writes:
> >> This notion has changed in a way that only the url (by that the
> >> name) should be copied on init. The default for everything else
> >> should come from .gitmodules or gits own default.
> > 
> > I think you need to be a bit careful here.  I do not think
> > everything should blindly default to .gitmodules (otherwise there
> > are obvious security implications as well as usability ones).
> I believe everything except the URL should default to .gitmodules,
> for the same reasons we already do that for fetch and ignore [1].
> But it should not do so blindly and take precautions that this only
> happens for safe values.

I think the "safety of .git/config vs. convenience of .gitmodules"
balance is going to break down differently for different folks.
That's why I proposed get_submodule_config() [1] and
submodule.<name>.active as an activation marker [2,3].  Then users can
move as much or as little of the submodule config from .gitmodules
into .git/config to strike the balance they feel is appropriate.  For
safety, maybe the default `init` should copy *everything* into
.git/config, after which users can remove stuff they'd like to
delegate to .gitmodules.


[1]: http://article.gmane.org/gmane.comp.version-control.git/210930
[2]: http://article.gmane.org/gmane.comp.version-control.git/211014
[3]: http://article.gmane.org/gmane.comp.version-control.git/211042

This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to