Hi Sebastian,

On Thu, 2 Jan 2014, Sebastian Schuberth wrote:

> On 02.01.2014 18:33, Johannes Schindelin wrote:
> > -- snip --
> > On Linux, we can get away with assuming that the directory separator is a
> > forward slash, but that is wrong in general. For that purpose, the
> > is_dir_sep() function was introduced a long time ago. By using it in
> > safe_create_leading_directories(), we proof said function for use on
> > platforms where the directory separator is different from Linux'.
> > -- snap --
> While I'd be fine with this, I do not think we really need it.

I also would have been fine with your commit message. But I knew Junio
wouldn't be.

> As you say, is_dir_sep() has been introduced a long time ago, so people
> should be aware of it, and it should also be immediately clear from the
> diff why using it is better than hard-coding '/'.
> That said, I see any further explanations on top of the commit message
> title is an added bonus, and as "just" a bonus a link to a pull request
> should be fine. You don't need to understand or appreciate the concept
> of pull requests in order to follow the link and read the text in there.

Well, you and I both know how easy GitHub's pull request made things for
us as well as for contributors. I really cannot thank Erik enough for
bullying me into using and accepting them.

But the commit messages of the merged pull requests are not exactly
stellar when you want the repositories to be self-contained, which is
however how I remember things are expected in git.git.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to