Matthieu Moy <matthieu....@grenoble-inp.fr> writes: > Nemina Amarasinghe <nemi...@gmail.com> writes: > >> Nemina Amarasinghe <neminaa <at> gmail.com> writes: >> >> Sorry for the first patch. Something went wrong. This is the correct one > > Please, re-read Documentation/SubmittingPatches. In short, don't inline > patch headers and don't forget the sign-off. > >> Subject: [PATCH] simplified the chain if() statements of >> install_brach_config() function in branch.c > > Keep the subject line short (ideally <50 characters), and avoid past > tense. We usually use imperative (the patch asks the codebase to > refactor itself => "simplify if statements ...". We usually prefix the > subject line with the place/subsystem where the change is done => > "branch.c: simplify if ...". > >> - else if (!remote_is_branch && origin) >> - printf_ln(rebasing ? >> - _("Branch %s set up to track remote ref %s by rebasing.") : >> - _("Branch %s set up to track remote ref %s."), >> - local, remote); >> - else if (!remote_is_branch && !origin) >> + else if (!remote_is_branch && (origin || !origin)) > > Is it me, or is (origin || !origin) a tautology?
Since it _is_ you, that question is a tautology because of its first part already. But the second one would be just as good. -- David Kastrup -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html