On Wed, May 14, 2014 at 11:26:54AM -0700, Jonathan Nieder wrote:

> "git grep" has other options that affect interpretation of the pattern
> which this patch does not help with:
>  * -v / --ignore-match: probably should disable this feature of -O.
>  * -E / --extended-regexp
>  * -P / --perl-regexp
>  * -F / --fixed-strings: ideally would auto-escape regex specials.
>  * -e<pattern1> --or -e<pattern2>
> And git grep -Ovi has a similar bug, for which the fix is to add
> \c to the pattern instead of passing an -I option.

We've already found the lines of interest to the user. It would be nice
if we could somehow point the pager at them by number, rather than
repeating the (slightly incompatible) search.

We can do "less +25", but that only points it to the first instance (and
doesn't highlight it), whereas the current code lets the repeat-search
find other instances. I don't think there's a way to queue up a set of
interesting lines to visit in less. At least I could not think of one.

This is more or less how I ended up at the design of contrib/git-jump,
which uses quickfix lists to make such a queue (only editors
understand those, not pagers, but I consider being dumped into the
editor a feature :) ).

> But as is, it's an improvement, so (except that "-i" should be
> replaced by "-I") it seems like a good change.

Agreed. Thanks for the list of problematic options.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to