On Mon, May 19, 2014 at 9:33 PM, Jonathan Nieder <jrnie...@gmail.com> wrote:
> Hi,
> Thomas Braun wrote:
>> pushing over the dump git protocol with a windows git client.
> I've never heard of the dump git protocol.  Do you mean the git
> protocol that's used with git:// URLs?
> [...]
>> Alternative approaches considered but deemed too invasive:
>> - Rewrite read/write wrappers in mingw.c in order to distinguish between
>>   a file descriptor which has a socket behind and a file descriptor
>>   which has a file behind.
> I assume here "too invasive" means "too much engineering effort"?
> It sounds like a clean fix, not too invasive at all.  But I can
> understand wanting a stopgap in the meantime.

Yeah, now that the problem seems to be understood, I don't think that
would be too bad. I recently killed off our previous write()-wrapper
in c9df6f4, but I see no reason why we can't add a new one.

Would we need to wrap both ends, shouldn't wrapping only reading be
good enough to prevent deadlocking?

compat/poll/poll.c already contains a function called IsSocketHandle
that is able to tell if a HANDLE points to a socket or not.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to