On Mon, Jul 28, 2014 at 08:35:52AM -0700, Junio C Hamano wrote:
> I am tempted to revert that series; it already caused "oops, this
> needs a further fix" before it hit 'master' at least once, and we do
> not want any more headaches at this point in the release cycle.
Yeah, that sounds reasonable to me. I'm a little doubtful of its value
(and maintainability) at all, but certainly I do not think it would be a
big deal to push it off for one more cycle if David wants to rework it.
If you do revert it, we may want a test like below. That will make sure
the case is covered for future attempts.
-- >8 --
Subject: [PATCH] t1402: check for refs ending with a dot
This has been illegal since cbdffe4 (check_ref_format():
tighten refname rules, 2009-03-21), but we never tested it.
Signed-off-by: Jeff King <p...@peff.net>
t/t1402-check-ref-format.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/t/t1402-check-ref-format.sh b/t/t1402-check-ref-format.sh
index 9aeb352..8d2f75f 100755
@@ -48,6 +48,7 @@ invalid_ref './foo/bar'
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html