Elia Pinto <gitter.spi...@gmail.com> writes: > Elia Pinto (3): > git.txt: document the new GIT_TRACE_CURL environment variable > imap-send.c: introduce the GIT_TRACE_CURL enviroment variable > http.c: implements the GIT_TRACE_CURL environment variable
I think 2 & 3 need to be swapped; otherwise 2 would refer to yet-to-be-invented curl_trace() function, and break the build without 3, no? Strictly speaking 1 should come at the end for the same reason, as setting GIT_TRACE_CURL after seeing that commit would not give users anything new. Other than that, I didn't find anything blatantly wrong ;-). Will nitpick individual patches later but I expect that it would be sufficient to locally tweak while queuing without rerolling. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
