gemmellr commented on PR #4237: URL: https://github.com/apache/activemq-artemis/pull/4237#issuecomment-1262504325
I cant unresolve things but I dont consider the 'can no longer tell which mechanism failed' thing to be resolved. For that and the very similar 'which login module is this logging for', the change significantly reduces the utility of those log messages. They either need the log messages adjusted to actually report what child class they are logging on behalf of, or would be better to retain the existing behaviour, albeit implemented slightly differently...e.g by supplying the class or the logger from the child 'user' class so the parent can log on its behalf (e.g like Netty lets you do for its logging) rather than relying on the getClass() in the abstract parent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
