gemmellr commented on PR #4237: URL: https://github.com/apache/activemq-artemis/pull/4237#issuecomment-1262527715
The precise implementation may have been a mistake, but there are other ways to acheive the same effect, which isnt unusual. The logging before was more useful than it will be with your change, where it will become less useful becuase you cant actually distinguish which of multiple things it is on behalf of. You mentioned not being able to find where its logging (which per above is effectively what the change itsealf does). Its relatively trivial to follow a logger name of a specific subclass to a shared-implementation in its immediate parent. There are multiple mechanisms or login module classes that some of those shared-impl log statments could be for, and previously the logs would inherently identified exactly which one it was happening for. With your change they will instead all indicate the abstract parent, making it impossible to tell what one the logging was for if there happens to be more than one in use at the time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
