clebertsuconic commented on code in PR #4237:
URL: https://github.com/apache/activemq-artemis/pull/4237#discussion_r983785094
##########
artemis-server/src/main/java/org/apache/activemq/artemis/spi/core/security/jaas/AbstractPrincipalLoginModule.java:
##########
@@ -31,12 +31,13 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import java.lang.invoke.MethodHandles;
/**
* Abstract login module that uses an external authenticated principal
*/
public abstract class AbstractPrincipalLoginModule implements AuditLoginModule
{
- private final Logger logger = LoggerFactory.getLogger(getClass());
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
Review Comment:
It's definitely no use to log.debug on an instance logger... that was a
mistake... we had no defined workspace when this was done...
if this was doing log.info() with some information for the user I would
agree with you.. .but log.debug() it's information for use on this case.... or
someone debugging the code.
There's no point on doing log.debug on a instance logger on this case... we
should remove them all.
We used to have others that I have historically replaced along the way..
it's just a mistake of stuff we used to do and it should be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
