michaelandrepearce commented on a change in pull request #2577: ARTEMIS-1604 
Artemis deadlock using MQTT Protocol
URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264410615
 
 

 ##########
 File path: 
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSessionCallback.java
 ##########
 @@ -36,6 +36,11 @@ public MQTTSessionCallback(MQTTSession session, 
MQTTConnection connection) throw
       this.connection = connection;
    }
 
+   @Override
+   public boolean supportsDirectDelivery() {
 
 Review comment:
   if its a deadlock issue in queue, this shouldn't be needed. We should avoid 
using a sledge hammer by disabling features. fix the deadlock not just disable 
stuff. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to