michaelandrepearce commented on a change in pull request #2577: ARTEMIS-1604
Artemis deadlock using MQTT Protocol
URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264431241
##########
File path:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSessionCallback.java
##########
@@ -36,6 +36,11 @@ public MQTTSessionCallback(MQTTSession session,
MQTTConnection connection) throw
this.connection = connection;
}
+ @Override
+ public boolean supportsDirectDelivery() {
Review comment:
@clebertsuconic i don't see why that impacts if it can direct deliver or
not, direct deliver in my understanding is if it can use the producer thread,
to avoid needing to context switch threads and async deliver, for perf benefit,
as long as transform is non blocking
I iterate though this bug if i understand the change and franz, is theres
deadlock in queueimpl. NOT the protocols, should fix just whats needed here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
