michaelandrepearce commented on a change in pull request #2577: ARTEMIS-1604 
Artemis deadlock using MQTT Protocol
URL: https://github.com/apache/activemq-artemis/pull/2577#discussion_r264436896
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ##########
 @@ -249,7 +253,7 @@
 
    private volatile boolean directDeliver = true;
 
-   private volatile boolean supportsDirectDeliver = true;
+   private volatile boolean supportsDirectDeliver = false;
 
 Review comment:
   @clebertsuconic if thats the case, then all the changes franz has done in 
QueueImpl are NOT needed. But looking through it does seem the issue IS in 
QueueImpl not MQTT, and actually CORE or AMQP would equally be exposed, thus we 
fix QueueImpl and other changes are not needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to