clebertsuconic commented on a change in pull request #2627: ARTEMIS-2311 
Dealing with Protocol conversions and JMSReplyTo
URL: https://github.com/apache/activemq-artemis/pull/2627#discussion_r276432580
 
 

 ##########
 File path: 
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/CoreAmqpConverter.java
 ##########
 @@ -530,4 +543,17 @@ private static byte destinationType(Destination 
destination) {
       throw new IllegalArgumentException("Unknown Destination Type passed to 
JMS Transformer.");
 
 Review comment:
   There are only 4 types of JMS Queues.. all of them part of destinationType 
check
   
   This is not used on JmsReply Any longer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to