clebertsuconic commented on a change in pull request #2627: ARTEMIS-2311
Dealing with Protocol conversions and JMSReplyTo
URL: https://github.com/apache/activemq-artemis/pull/2627#discussion_r276440298
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/CoreAmqpConverter.java
##########
@@ -173,9 +174,12 @@ public static AMQPMessage fromCore(ICoreMessage
coreMessage) throws Exception {
properties.setTo(toAddress(destination));
maMap.put(JMS_DEST_TYPE_MSG_ANNOTATION, destinationType(destination));
}
- Destination replyTo = message.getJMSReplyTo();
Review comment:
even so, it would be duplication. Those JMS Client classes are not available
at the server's. It would be duplication anyways.
This is just at the conversion side for this property.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services