clebertsuconic commented on a change in pull request #2627: ARTEMIS-2311
Dealing with Protocol conversions and JMSReplyTo
URL: https://github.com/apache/activemq-artemis/pull/2627#discussion_r276440481
##########
File path:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java
##########
@@ -196,7 +200,21 @@ private OpenWireMessageConverter() {
final ActiveMQDestination replyTo = messageSend.getReplyTo();
if (replyTo != null) {
- putMsgReplyTo(replyTo, marshaller, coreMessage);
+ if (replyTo instanceof TemporaryQueue) {
+ MessageUtil.setJMSReplyTo(coreMessage,
org.apache.activemq.artemis.jms.client.ActiveMQDestination.TEMP_QUEUE_QUALIFED_PREFIX
+ (((TemporaryQueue) replyTo).getQueueName()));
Review comment:
it would mean duplciation regardless. The client JMS implementation is not
available at the server's. This is only needed when converting this property
between protocols.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
