clebertsuconic commented on a change in pull request #2627: ARTEMIS-2311
Dealing with Protocol conversions and JMSReplyTo
URL: https://github.com/apache/activemq-artemis/pull/2627#discussion_r276441613
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/CoreAmqpConverter.java
##########
@@ -530,4 +543,17 @@ private static byte destinationType(Destination
destination) {
throw new IllegalArgumentException("Unknown Destination Type passed to
JMS Transformer.");
Review comment:
@michaelandrepearce there's currently an expectation that if you're sending
AMQP to be converted, the message has to be in a certain format anyways. It's
not always possible to convert everything between protocols.
If NOT JMS, send AMQP, receive AMQP, and don't deal with conversions.
This specific bit wouldn't be a problem though.
Also: non JMS Conversions are currently a problem regardless of what I'm
doing here. it's beyond the scope.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
