tabish121 commented on a change in pull request #2695: ARTEMIS-2372 Filtering
on Message Annotations
URL: https://github.com/apache/activemq-artemis/pull/2695#discussion_r290927683
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpExpiredMessageTest.java
##########
@@ -108,9 +109,16 @@ public void testExpiryThroughTTL() throws Exception {
connection = addConnection(client.connect());
session = connection.createSession();
- AmqpReceiver receiverDLQ =
session.createReceiver(getDeadLetterAddress());
+ AmqpReceiver receiverDLQ =
session.createReceiver(getDeadLetterAddress(), "_AMQ_ORIG_ADDRESS='" +
getQueueName() + "'");
Review comment:
Instead of disturbing an existing test to validate new functionality you
should really be writing new tests that cover the feature in depth with both
positive and negative validation tests to ensure that future changes don't
break and that the feature works as intended.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
