tabish121 commented on a change in pull request #2695: ARTEMIS-2372 Filtering
on Message Annotations
URL: https://github.com/apache/activemq-artemis/pull/2695#discussion_r290938313
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
##########
@@ -1263,7 +1263,10 @@ public Long getLongProperty(String key) throws
ActiveMQPropertyConversionExcepti
@Override
public Object getObjectProperty(String key) {
- if (key.equals(MessageUtil.TYPE_HEADER_NAME.toString())) {
+
+ if
(key.startsWith(AMQPMessageSupport.JMS_AMQP_MESSAGE_ANNOTATION_PREFIX)) {
Review comment:
You are putting illegal message annotations into the message from what I can
tell, and the test seems to validate that. The message that is received has
annotations which are of the form ({_AMQ_ORIG_QUEUE=testExpiryThroughTTL,
_AMQ_ORIG_ADDRESS=testExpiryThroughTTL, _AMQ_ORIG_MESSAGE_ID=69,
_AMQ_ACTUAL_EXPIRY=1559769271365}) which is illegal according the spec section
I posted and a receiver is technically required to close the connection if it
sees them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
