tabish121 commented on a change in pull request #2695: ARTEMIS-2372 Filtering
on Message Annotations
URL: https://github.com/apache/activemq-artemis/pull/2695#discussion_r290939185
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpExpiredMessageTest.java
##########
@@ -108,9 +109,16 @@ public void testExpiryThroughTTL() throws Exception {
connection = addConnection(client.connect());
session = connection.createSession();
- AmqpReceiver receiverDLQ =
session.createReceiver(getDeadLetterAddress());
+ AmqpReceiver receiverDLQ =
session.createReceiver(getDeadLetterAddress(), "_AMQ_ORIG_ADDRESS='" +
getQueueName() + "'");
Review comment:
I mean write a real set of tests that validate that it applied to a given
property and not others etc. It really isn't that hard and given how long the
broker tests take I'm pretty sure nobody will break out the torches and
pitchforks. Although given what the broker is doing is creating illegal
message content maybe the tests should check for that not happening instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
