michaelpearce-gain commented on a change in pull request #2750: ARTEMIS-2399 Improve performance when there are a lot of subscribers URL: https://github.com/apache/activemq-artemis/pull/2750#discussion_r303660459
########## File path: tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/jmx/JmxConnectionTest.java ########## @@ -27,8 +27,8 @@ import java.rmi.server.RemoteRef; import io.netty.util.internal.PlatformDependent; -import io.netty.util.internal.shaded.org.jctools.util.UnsafeAccess; import org.apache.activemq.artemis.tests.smoke.common.SmokeTestBase; +import org.jctools.util.UnsafeAccess; Review comment: @franz1981 what occurs post java 8 here? Same with any internal Unsafe access in the MPSC Queue used , just worried we tune for java 8 where unsafe is king, and then find on java 11 perf is lost, and we rely on a new lib that isnt needed.. It might be all good, i just want to play dumb and make sure, and i know jctools is a bit of your area of expertise, and will know the answer outright, and just tell me its no worries. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
