michaelpearce-gain commented on a change in pull request #2750: ARTEMIS-2399
Improve performance when there are a lot of subscribers
URL: https://github.com/apache/activemq-artemis/pull/2750#discussion_r303787724
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -324,13 +325,7 @@ public String debug() {
out.println("consumer: " + holder.consumer.debug());
}
- for (MessageReference reference : intermediateMessageReferences) {
- out.print("Intermediate reference:" + reference);
- }
-
- if (intermediateMessageReferences.isEmpty()) {
- out.println("No intermediate references");
- }
+ out.println("Intermediate reference size is " +
intermediateMessageReferences.size());
Review comment:
Do we need MpscUnboundedArrayQueue then in this PR to make it work? Im
conscious of removing useful debugging features. Perf shouldnt be at the cost
of feature / operational need.
Can always be re-added back once it supports? In a later PR perf improvement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
