michaelpearce-gain commented on a change in pull request #2750: ARTEMIS-2399
Improve performance when there are a lot of subscribers
URL: https://github.com/apache/activemq-artemis/pull/2750#discussion_r303794549
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -324,13 +325,7 @@ public String debug() {
out.println("consumer: " + holder.consumer.debug());
}
- for (MessageReference reference : intermediateMessageReferences) {
- out.print("Intermediate reference:" + reference);
- }
-
- if (intermediateMessageReferences.isEmpty()) {
- out.println("No intermediate references");
- }
+ out.println("Intermediate reference size is " +
intermediateMessageReferences.size());
Review comment:
So debug like this only make it into code if it was needed at some point to
debug an operational issue, as such i would suggest it was needed. My question
is how much perf improvement is actually gained from this one particular
change. I would expect the real perf was in the change in paging logic not the
change of queue, which to me anyhow seems a little unrelated to improving
performance for lots of subscribers (the jira) because its actually anyhow on
the ingress to the core queue, not the consumption.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
