michaelpearce-gain commented on a change in pull request #2802: ARTEMIS-2457
implement ring queue
URL: https://github.com/apache/activemq-artemis/pull/2802#discussion_r317416551
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -3436,6 +3503,11 @@ public void postAcknowledge(final MessageReference ref,
AckReason reason) {
queue.decDelivering(ref);
+ // this is done to tell the difference between actual acks and just a
closed consumer in the non-destructive use-case
+ if (isNonDestructive() && reason == AckReason.NORMAL) {
Review comment:
field access?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services