michaelpearce-gain commented on a change in pull request #2802: ARTEMIS-2457 
implement ring queue
URL: https://github.com/apache/activemq-artemis/pull/2802#discussion_r317416759
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ##########
 @@ -3933,6 +4005,37 @@ void scheduleSlowConsumerReaper(AddressSettings 
settings) {
       }
    }
 
+   private void enforceRing() {
 
 Review comment:
   could ringsize != -1 check be done here, will allow better escaping and 
inlining where not being used., e.g. avoids need to call into method below 
which is many lines long, and unlikely to be inlined  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to