michaelpearce-gain commented on a change in pull request #2802: ARTEMIS-2457 
implement ring queue
URL: https://github.com/apache/activemq-artemis/pull/2802#discussion_r317416955
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
 ##########
 @@ -3460,7 +3532,7 @@ public void postAcknowledge(final MessageReference ref, 
AckReason reason) {
          message = null;
       }
 
-      if (message == null)
+      if (message == null || (isNonDestructive() && reason == 
AckReason.NORMAL))
 
 Review comment:
   by field access

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to