fvaleri commented on a change in pull request #2954: ARTEMIS-2608 Fix 
ClassCastException on binary properties retrieval
URL: https://github.com/apache/activemq-artemis/pull/2954#discussion_r372794221
 
 

 ##########
 File path: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java
 ##########
 @@ -610,7 +613,7 @@ private static ActiveMQMessage 
toAMQMessage(MessageReference reference,
          amqMsg.setCorrelationId(corrId.toString());
       }
 
-      final byte[] dsBytes = (byte[]) 
coreMessage.getObjectProperty(AMQ_MSG_DATASTRUCTURE);
+      final byte[] dsBytes = getBytesPropertyOrNull(coreMessage, 
AMQ_MSG_DATASTRUCTURE);
 
 Review comment:
   > > > Send a message to the broker using OpenWire client
   > 
   > Perhaps we could fix whatever conversion made that happen?
   
   Agree. I think the problem is located in the AMQP module but it needs more 
investigation. Can we create another Jira for that and release this fix?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to