[GitHub] [activemq-artemis] fvaleri edited a comment on issue #2954: ARTEMIS-2608 Fix ClassCastException on binary properties retrieval

[GitBox]

fvaleri edited a comment on issue #2954: ARTEMIS-2608 Fix ClassCastException on 
binary properties retrieval
URL: https://github.com/apache/activemq-artemis/pull/2954#issuecomment-602618829
 
 
   @gemmellr is right. The problem is in the `AmqpCoreConverter.setProperty` 
method which convert proton-j's Binary to String instead of byte[]:
   
   ```java
   ...
       } else if (value instanceof Binary) {
            msg.setStringProperty(key, value.toString());
   ```
   
   Please review my last commit which fixes the issue, adds a converter test 
and a bit of refactoring to have separate classes for CoreOpenWireConverter and 
OpenWireCoreConverter (much like in the AMQP protocol module).
   
   Thanks.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services