michaelandrepearce commented on a change in pull request #2954: ARTEMIS-2608
Fix ClassCastException on binary properties retrieval
URL: https://github.com/apache/activemq-artemis/pull/2954#discussion_r389312347
##########
File path:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java
##########
@@ -610,7 +613,7 @@ private static ActiveMQMessage
toAMQMessage(MessageReference reference,
amqMsg.setCorrelationId(corrId.toString());
}
- final byte[] dsBytes = (byte[])
coreMessage.getObjectProperty(AMQ_MSG_DATASTRUCTURE);
+ final byte[] dsBytes = getBytesPropertyOrNull(coreMessage,
AMQ_MSG_DATASTRUCTURE);
Review comment:
> Hi @jbertram @clebertsuconic , what about merging this?
reading others reviews, isn't this waiting of finding the underlying cause
why the properties go missing in AMQP? we should be fixing underlying issue,
not plastering over.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
