jbertram commented on a change in pull request #3049: ARTEMIS-2681 timestamp
not set on notif msgs
URL: https://github.com/apache/activemq-artemis/pull/3049#discussion_r398203947
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/SecurityNotificationTest.java
##########
@@ -155,6 +163,8 @@ public void testCONSUMER_CREATED() throws Exception {
Assert.assertEquals("guest",
notifications[0].getObjectProperty(ManagementHelper.HDR_VALIDATED_USER).toString());
Assert.assertEquals(address.toString(),
notifications[0].getObjectProperty(ManagementHelper.HDR_ADDRESS).toString());
Assert.assertEquals(SimpleString.toSimpleString("unavailable"),
notifications[0].getSimpleStringProperty(ManagementHelper.HDR_CERT_SUBJECT_DN));
+ Assert.assertTrue(notifications[0].getTimestamp() >= start);
+ Assert.assertTrue((Long)
notifications[0].getObjectProperty(ManagementHelper.HDR_NOTIFICATION_TIMESTAMP)
>= start);
Review comment:
Are you saying we should assert `getTimestamp() == start` or something else?
Both timestamps should be the same and both should be *after* `start`. I'm just
asserting the latter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
