jbertram commented on a change in pull request #3049: ARTEMIS-2681 timestamp
not set on notif msgs
URL: https://github.com/apache/activemq-artemis/pull/3049#discussion_r398880178
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/NotificationTest.java
##########
@@ -79,13 +79,17 @@ public void testBINDING_ADDED() throws Exception {
NotificationTest.flush(notifConsumer);
+ long start = System.currentTimeMillis();
session.createQueue(address, queue, durable);
//the first message received will be for the address creation
ClientMessage[] notifications = NotificationTest.consumeMessages(2,
notifConsumer);
Assert.assertEquals(BINDING_ADDED.toString(),
notifications[1].getObjectProperty(ManagementHelper.HDR_NOTIFICATION_TYPE).toString());
Assert.assertEquals(queue.toString(),
notifications[1].getObjectProperty(ManagementHelper.HDR_ROUTING_NAME).toString());
Assert.assertEquals(address.toString(),
notifications[1].getObjectProperty(ManagementHelper.HDR_ADDRESS).toString());
+ Assert.assertTrue(notifications[1].getTimestamp() > start);
+ Assert.assertTrue((long)
notifications[1].getObjectProperty(ManagementHelper.HDR_NOTIFICATION_TIMESTAMP)
>= start);
Review comment:
It just means that the notification was sent *after* the binding was added.
It's a simple validation of the timestamp.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
