gemmellr commented on a change in pull request #3851:
URL: https://github.com/apache/activemq-artemis/pull/3851#discussion_r749468754
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/security/SecurityTest.java
##########
@@ -2564,4 +2582,21 @@ private void checkUserSendNoReceive(final String queue,
final ClientSession conn
fail("Invalid Exception type:" + e.getType());
}
}
+
+ public static class MD5SensitiveDataCodec implements
SensitiveDataCodec<String> {
Review comment:
Same general comment as before. The DigestUtils class being used in the
impl has many options, so I see no reason to use MD5 at this stage, even if it
is only for a test impl.
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/DefaultSensitiveStringCodec.java
##########
@@ -79,6 +79,21 @@ public void init(Map<String, String> params) throws
Exception {
}
}
+ @Override
+ public boolean compare(Object value, Object encodedValue) {
+ if (encodedValue instanceof String == false) {
+ throw new IllegalArgumentException("Not supported encodedValue type:
" + encodedValue.getClass().getName());
+ }
Review comment:
> I would not add another condition to check if value is null just to
throw NPE
Fair enough, I would, given all the other checks. Calling
Objects.requireNonNull isnt overly arduous.
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/security/MD5SensitiveDataCodec.java
##########
@@ -0,0 +1,38 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.tests.integration.security;
+
+import org.apache.activemq.artemis.utils.SensitiveDataCodec;
+import org.apache.commons.codec.digest.DigestUtils;
+
+public class MD5SensitiveDataCodec implements SensitiveDataCodec<String> {
Review comment:
Think you forgot to remove this when adding the other class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
