gemmellr commented on a change in pull request #3851:
URL: https://github.com/apache/activemq-artemis/pull/3851#discussion_r753109359
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SecureHashProcessor.java
##########
@@ -33,6 +33,6 @@ public String hash(String plainText) throws Exception {
//storedValue must take form of ENC(...)
public boolean compare(char[] inputValue, String storedValue) {
String storedHash = storedValue.substring(4, storedValue.length() - 1);
- return codec.verify(inputValue, storedHash);
+ return codec.compare(inputValue, storedHash);
Review comment:
The existing stuff is already a little messy and this expands it and
makes it more complicated to follow overall. It seems rather unnecessary when
it could instead be making it nicer and simpler even while adding/exposing this
functionality. The 'could be another PR' changes tends not to happen, just
leaving the earlier stuff layering the onion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
