gemmellr commented on a change in pull request #3851:
URL: https://github.com/apache/activemq-artemis/pull/3851#discussion_r751194210
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SecureHashProcessor.java
##########
@@ -33,6 +33,6 @@ public String hash(String plainText) throws Exception {
//storedValue must take form of ENC(...)
public boolean compare(char[] inputValue, String storedValue) {
String storedHash = storedValue.substring(4, storedValue.length() - 1);
- return codec.verify(inputValue, storedHash);
+ return codec.compare(inputValue, storedHash);
Review comment:
Ahhh. I've missed that the verify method isnt new, its an existing
method defined in DefaultSensitiveStringCodec that you just implemented in
another bit of DefaultSensitiveStringCodec. But added the essentially same
compare method to the SensitiveDataCodec interface.
My main thought is still why have both, and why does the private
CodecAlgorithm class need to exist within DefaultSensitiveStringCodec at all,
just to define methods that are basically already defined on the
SensitiveDataCodec interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
